[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake/acpi/serialio.asl: Don't advertise unavailable d...

[Angel Pons (Code Review)]

Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44198 )

Change subject: soc/intel/cannonlake/acpi/serialio.asl: Don't advertise unavailable devices
......................................................................

soc/intel/cannonlake/acpi/serialio.asl: Don't advertise unavailable devices

On PCH-H the I2C4 0:19.0 device isn't usable and thus 0:19.1 and
0:19.2 can't be detected using standard PCI probing.

Remove I2C4, I2C5 and UART2 from generic ASL code on PCH-H platforms
that advertise its PCI conformance by the _ADR attribute.

Change-Id: I89f9ab7d4afb2e7d1b1e24d072adf99e0da6fecf
Signed-off-by: Patrick Rudolph 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44198
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
---
M src/soc/intel/cannonlake/acpi/serialio.asl
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/src/soc/intel/cannonlake/acpi/serialio.asl b/src/soc/intel/cannonlake/acpi/serialio.asl
index e4a675e..0551191 100644
--- a/src/soc/intel/cannonlake/acpi/serialio.asl
+++ b/src/soc/intel/cannonlake/acpi/serialio.asl
@@ -26,6 +26,7 @@
    Name (_DDN, "Serial IO I2C Controller 3")
 }

+#if !CONFIG(SOC_INTEL_CANNONLAKE_PCH_H)
 Device (I2C4)
 {
    Name (_ADR, 0x00190000)
@@ -37,6 +38,7 @@
    Name (_ADR, 0x00190001)
    Name (_DDN, "Serial IO I2C Controller 5")
 }
+#endif

Device (SPI0)
 {
@@ -68,8 +70,10 @@
    Name (_DDN, "Serial IO UART Controller 1")
 }

+#if !CONFIG(SOC_INTEL_CANNONLAKE_PCH_H)
 Device (UAR2)
 {
    Name (_ADR, 0x00190002)
    Name (_DDN, "Serial IO UART Controller 2")
 }
+#endif