Attention is currently required from: Jason Glenesk, Marshall Dawson.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50343 )
Change subject: mb/amd/majolica: Add chromeos support
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/amd/majolica/Kconfig:
https://review.coreboot.org/c/coreboot/+/50343/comment/74195a55_301b3210
PS2, Line 48:
I'm a little surprised you didn't need LP_DEFCONFIG_OVERRIDE. […]
So I built this with CrOS depthcharge. The CrOS build has CONFIG_PAYLOAD_NONE=y and then the chromeos-bootimage ebuild adds depthcharge to the image. I wasn't even aware that coreboot supported building depthcharge as a payload... Is that even tested or used?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50343
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I43f0c6e33649332057f41f8813a86571b06032f1
Gerrit-Change-Number: 50343
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Tue, 09 Feb 2021 16:18:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-MessageType: comment