[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/skylake: Correct GPIO pointer assignment

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32797 )

Change subject: soc/intel/skylake: Correct GPIO pointer assignment
......................................................................

soc/intel/skylake: Correct GPIO pointer assignment

We need to store the acpi_gpio struct, not save its address.

Found-by: Clang Static Analyzer
Signed-off-by: Jacob Garber 
Change-Id: I41c8bf10ce72bec736da97ccc33f9ada49804dc1
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32797
Tested-by: build bot (Jenkins) 
Reviewed-by: Martin Roth 
---
M src/soc/intel/skylake/sd.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved

diff --git a/src/soc/intel/skylake/sd.c b/src/soc/intel/skylake/sd.c
index 12c6abe..571d3e7 100644
--- a/src/soc/intel/skylake/sd.c
+++ b/src/soc/intel/skylake/sd.c
@@ -35,7 +35,7 @@
    	gpio->pin_count = 1;
    	gpio->pins[0] = config->sdcard_cd_gpio_default;
    } else
-		gpio = &config->sdcard_cd_gpio;
+		*gpio = config->sdcard_cd_gpio;

return 0;
 }