Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44480 )
Change subject: mb/google/zork: Switch zork to use spd_tools ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44480/3/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/berknip/spd/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/44480/3/src/mainboard/google/zork/v... PS3, Line 3: This Makefile is missing the "MEMORY_TYPE = ddr4" declaration.
You will want to regenerate these now that all changes to the DDR4 SPD generation tool are complete (recent changes to the global parts list will likely have changed SPD names and mappings). FYI, the latest gen_part_id changes will add the "MEMORY_TYPE = ddr4" to the Makefile.