14 May
2020
14 May
'20
2:45 a.m.
Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40897 )
Change subject: mb/google/hatch: Fix Puff variants rom size from 32768 -> 16384 KB ......................................................................
Patch Set 3:
(1 comment)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/40897/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/40897/3/src/mainboard/google/hatch/... PS3, Line 21: config BOARD_GOOGLE_DUFFY I think these need entries in Kconfig for setting MAINBOARD_PART_NUMBER and VARIANT_DIR.
--
To view, visit https://review.coreboot.org/c/coreboot/+/40897
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic336168ea1a0055c30f718f5540209d2cf69d029
Gerrit-Change-Number: 40897
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Sam McNally sammc@google.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 14 May 2020 08:45:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment