Vinodkumarreddy Polimera has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39614 )
Change subject: sc7180: Add display dsi interface programming. ......................................................................
Patch Set 22:
(4 comments)
addressed all the comments
https://review.coreboot.org/c/coreboot/+/39614/16/src/soc/qualcomm/sc7180/di... File src/soc/qualcomm/sc7180/display/dsi.c:
https://review.coreboot.org/c/coreboot/+/39614/16/src/soc/qualcomm/sc7180/di... PS16, Line 1: /* : * This file is part of the coreboot project. : * : * Copyright 2020 Qualcomm Inc. : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License version 2 and : * only version 2 as published by the Free Software Foundation. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */
/* SPDX-License-Identifier: GPL-2. […]
Done
https://review.coreboot.org/c/coreboot/+/39614/16/src/soc/qualcomm/sc7180/di... PS16, Line 142: goto wait4video_error;
please why don't use "return ret;" ?
Done
https://review.coreboot.org/c/coreboot/+/39614/16/src/soc/qualcomm/sc7180/di... File src/soc/qualcomm/sc7180/display/target_sc7180.c:
https://review.coreboot.org/c/coreboot/+/39614/16/src/soc/qualcomm/sc7180/di... PS16, Line 15: : #include <device/mmio.h> : #include <lib.h> : #include <console/console.h> : #include <delay.h> : #include <device/device.h> : #include <edid.h> : #include <stdlib.h> : #include <string.h> : #include <soc/display/panel.h> : #include <soc/display/msm_panel.h> : #include <soc/display/mdssreg.h> : #include <soc/display/mipi_dsi.h> : #include <soc/display/panel_display.h> : #include <soc/display/target_sc7180.h> : #include <gpio.h> : #include <soc/gpio.h>
please include only what you use
Done
https://review.coreboot.org/c/coreboot/+/39614/19/src/soc/qualcomm/sc7180/di... File src/soc/qualcomm/sc7180/display/target_sc7180.c:
https://review.coreboot.org/c/coreboot/+/39614/19/src/soc/qualcomm/sc7180/di... PS19, Line 75: }
I haven't looked closely at this patch yet but you shouldn't have anything like this in SoC code eit […]
Done