Attention is currently required from: Paul Menzel, Mario Scheithauer, Werner Zeh, Felix Held.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54911 )
Change subject: mb/siemens/{mc_apl2,...,mc_apl6}: Do early UART pad configuration
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/54911/comment/f4eea108_53932f25
PS3, Line 9: With commit 405f2296892c10a48db50cd66c2eb364cde0806e the UART pad
Note, in the commit message it’s only for reference, and not for security. […]
I agree with Paul here. Even if there was a collision, it wouldn't *really* be a problem, since the headline was given, too. And even if it wasn't and there are three colliding changes, chances are so damn small that these two other changes would be anyhow related. So, the worst thing that could happen is, that someone would have to look at two (three) changes instead of one.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54911
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If78726d9b141e4e7580cca3267f49c1a5b95d7fa
Gerrit-Change-Number: 54911
Gerrit-PatchSet: 4
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sat, 29 May 2021 13:37:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment