Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44205 )
Change subject: soc/intel/{cnl,icl,jsl,tgl}: Use Bus Master for setting up PWRMBASE ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/c/coreboot/+/44205/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44205/1//COMMIT_MSG@9 PS1, Line 9: This patch ensures that bootblock/pch.c
In `bootblock/pch.c`, clear PCI_COMMAND_MASTER ...
Ack
https://review.coreboot.org/c/coreboot/+/44205/1//COMMIT_MSG@10 PS1, Line 10: prior to program
`prior to programming` or `before programming`
Ack
https://review.coreboot.org/c/coreboot/+/44205/1//COMMIT_MSG@13 PS1, Line 13: performs
perform
Ack
https://review.coreboot.org/c/coreboot/+/44205/1//COMMIT_MSG@13 PS1, Line 13: beiow
be*l*ow
Ack
https://review.coreboot.org/c/coreboot/+/44205/1//COMMIT_MSG@14 PS1, Line 14: _
replace `_` with a space
Ack
https://review.coreboot.org/c/coreboot/+/44205/1//COMMIT_MSG@15 PS1, Line 15: instread
instead of
Ack