Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32144 )
Change subject: Add default boards for qemu, that has VPD partitions. ......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/#/c/32144/3/src/mainboard/emulation/qemu-i440fx/... File src/mainboard/emulation/qemu-i440fx/board.fmd:
https://review.coreboot.org/#/c/32144/3/src/mainboard/emulation/qemu-i440fx/... PS3, Line 3: # | unspecified | there's no unspecified in your fmap
https://review.coreboot.org/#/c/32144/3/src/mainboard/emulation/qemu-i440fx/... PS3, Line 9: 4278190080 offset in hex too
https://review.coreboot.org/#/c/32144/3/src/mainboard/emulation/qemu-i440fx/... PS3, Line 10: BIOS@0 0x1000000 { the default size is 256KB as set per Kconfig BOARD_ROMSIZE_KB_256
https://review.coreboot.org/#/c/32144/3/src/mainboard/emulation/qemu-q35/boa... File src/mainboard/emulation/qemu-q35/board.fmd:
https://review.coreboot.org/#/c/32144/3/src/mainboard/emulation/qemu-q35/boa... PS3, Line 3: # | unspecified | there's no unspecified in the fmap
https://review.coreboot.org/#/c/32144/3/src/mainboard/emulation/qemu-q35/boa... PS3, Line 10: BIOS@0 0x1000000 { the default size is 2MiB per Kconfig BOARD_ROMSIZE_KB_2048