build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40736 )
Change subject: md/cedarisland_crb: rework GPIOs configuration using macros ......................................................................
Patch Set 5:
(10 comments)
https://review.coreboot.org/c/coreboot/+/40736/5/src/mainboard/intel/cedaris... File src/mainboard/intel/cedarisland_crb/include/gpio.h:
https://review.coreboot.org/c/coreboot/+/40736/5/src/mainboard/intel/cedaris... PS5, Line 177: _PAD_CFG_STRUCT(GPP_C10, PAD_FUNC(GPIO) | PAD_RESET(RSMRST) | PAD_CFG0_TRIG_OFF | PAD_CFG0_RX_POL_NONE | PAD_BUF(NO_DISABLE), PAD_CFG_OWN_GPIO(ACPI) | PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/40736/5/src/mainboard/intel/cedaris... PS5, Line 319: _PAD_CFG_STRUCT(GPP_I4, PAD_FUNC(GPIO) | PAD_RESET(RSMRST) | PAD_CFG0_TRIG_OFF | PAD_CFG0_RX_POL_NONE | PAD_BUF(NO_DISABLE), PAD_CFG_OWN_GPIO(ACPI) | PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/40736/5/src/mainboard/intel/cedaris... PS5, Line 362: _PAD_CFG_STRUCT(GPP_J13, PAD_FUNC(GPIO) | PAD_RESET(RSMRST) | PAD_CFG0_TRIG_OFF | PAD_CFG0_RX_POL_NONE | PAD_BUF(NO_DISABLE), PAD_CFG_OWN_GPIO(ACPI) | PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/40736/5/src/mainboard/intel/cedaris... PS5, Line 366: _PAD_CFG_STRUCT(GPP_J15, PAD_FUNC(GPIO) | PAD_RESET(RSMRST) | PAD_CFG0_TRIG_OFF | PAD_CFG0_RX_POL_NONE | PAD_BUF(NO_DISABLE), PAD_CFG_OWN_GPIO(ACPI) | PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/40736/5/src/mainboard/intel/cedaris... PS5, Line 460: _PAD_CFG_STRUCT(GPP_H0, PAD_FUNC(GPIO) | PAD_RESET(RSMRST) | PAD_CFG0_TRIG_OFF | PAD_CFG0_RX_POL_NONE | PAD_BUF(NO_DISABLE), PAD_CFG_OWN_GPIO(ACPI) | PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/40736/5/src/mainboard/intel/cedaris... PS5, Line 464: _PAD_CFG_STRUCT(GPP_H2, PAD_FUNC(GPIO) | PAD_RESET(RSMRST) | PAD_CFG0_TRIG_OFF | PAD_CFG0_RX_POL_NONE | PAD_BUF(NO_DISABLE), PAD_CFG_OWN_GPIO(ACPI) | PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/40736/5/src/mainboard/intel/cedaris... PS5, Line 466: _PAD_CFG_STRUCT(GPP_H3, PAD_FUNC(GPIO) | PAD_RESET(RSMRST) | PAD_CFG0_TRIG_OFF | PAD_CFG0_RX_POL_NONE | PAD_BUF(NO_DISABLE), PAD_CFG_OWN_GPIO(ACPI) | PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/40736/5/src/mainboard/intel/cedaris... PS5, Line 468: _PAD_CFG_STRUCT(GPP_H4, PAD_FUNC(GPIO) | PAD_RESET(RSMRST) | PAD_CFG0_TRIG_OFF | PAD_CFG0_RX_POL_NONE | PAD_BUF(NO_DISABLE), PAD_CFG_OWN_GPIO(ACPI) | PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/40736/5/src/mainboard/intel/cedaris... PS5, Line 473: _PAD_CFG_STRUCT(GPP_H7, PAD_FUNC(GPIO) | PAD_RESET(RSMRST) | PAD_CFG0_TRIG_OFF | PAD_CFG0_RX_POL_NONE | PAD_BUF(NO_DISABLE), PAD_CFG_OWN_GPIO(ACPI) | PAD_PULL(NONE)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/40736/5/src/mainboard/intel/cedaris... PS5, Line 477: _PAD_CFG_STRUCT(GPP_H9, PAD_FUNC(GPIO) | PAD_RESET(RSMRST) | PAD_CFG0_TRIG_OFF | PAD_CFG0_RX_POL_NONE | PAD_BUF(NO_DISABLE), PAD_CFG_OWN_GPIO(ACPI) | PAD_PULL(NONE)), line over 96 characters