Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39125 )
Change subject: mb/kontron/986lcd-m: Use `winbond_enable_serial()` ......................................................................
Patch Set 1:
winbond_enable_serial() is used to enable the port for console purposes, I assume? Not setting the IRQ shouldn't be a problem, but... there is a lot going on here that shouldn't be necessary beside these IRQ settings. ramstage should take care of most of it.
So, I don't see what this fixes. It doesn't clean up all the early_init code, only parts of it, and only by accident. Which might make the whole story more confusing (currently, it's just configuring the whole SIO, with this change, console setup is mixed in) if somebody wants to clean it up in the future.
If somebody wants to really clean it up (look into each line and decide if it needs to be done early), I'd be happy to test that.