[coreboot-gerrit] Change in ...coreboot[master]: mb/google/hatch: Update GPIO settings

[Rizwan Qureshi (Code Review)]

Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32176 )

Change subject: mb/google/hatch: Update GPIO settings
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/#/c/32176/4/src/mainboard/google/hatch/variants/... 
File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/32176/4/src/mainboard/google/hatch/variants/... 
PS4, Line 32: PAD_NC(GPP_A7, NONE),
> What about this? Don't you need NF here?

CS1 is not being configured in FSP.

https://review.coreboot.org/#/c/32176/4/src/mainboard/google/hatch/variants/... 
PS4, Line 332: NATIVE
> Is this the recommendation for SD controller or for all controllers?

This is only for SD Controller.