Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40586 )
Change subject: mb/google/octopus/variants/garg: update Garfour SKU ID ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40586/2/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/garg/include/variant/sku.h:
https://review.coreboot.org/c/coreboot/+/40586/2/src/mainboard/google/octopu... PS2, Line 16: TS_GARFOUR Can it be renamed as SKU_49_2A2C_TS?
https://review.coreboot.org/c/coreboot/+/40586/2/src/mainboard/google/octopu... PS2, Line 17: SKU_50_HDMI_GARFOUR Just SKU_50_HDMI is sufficient. Garfour is probably the SKU name and no need to mention that.