Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34817 )
Change subject: Add buffer_to/from_fifo32(_prefix) helpers
......................................................................
Patch Set 2: Code-Review+2
sounds like a good idea, although I think you can move the rockchip changes to its own CL.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34817
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifcf37c6d56f949f620c347df05439b05c3b8d77d
Gerrit-Change-Number: 34817
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 12 Aug 2019 02:54:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment