build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22872 )
Change subject: security/crypto: Add crypto primitives for hashing data ......................................................................
Patch Set 24:
(12 comments)
https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash.h File src/security/crypto/hash.h:
https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash.h@186 PS24, Line 186: * if <alg> is invalid. please, no space before tabs
https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha1.c File src/security/crypto/hash/sha1.c:
https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha1.c@184 PS24, Line 184: while ((ctx->count % sizeof(ctx->buf)) != (sizeof(ctx->buf) - 8)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha1.c@193 PS24, Line 193: for (i = 0; i < 5; i++) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha1.c@277 PS24, Line 277: while ((ctx->count % sizeof(ctx->buf)) != (sizeof(ctx->buf) - 8)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha256.c File src/security/crypto/hash/sha256.c:
https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha256.c@1... PS24, Line 106: for (i = 0; i < 8; i++) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha256.c@1... PS24, Line 142: for (j = 0; j < 16; j++) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha256.c@1... PS24, Line 146: for (j = 16; j < 64; j++) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha256.c@1... PS24, Line 150: for (j = 0; j < 8; j++) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha256.c@1... PS24, Line 168: for (j = 0; j < 8; j++) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha512.c File src/security/crypto/hash/sha512.c:
https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha512.c@2... PS24, Line 293: for (j = 0; j < 16; j++) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha512.c@2... PS24, Line 297: for (j = 16; j < 80; j++) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha512.c@3... PS24, Line 301: for (j = 0; j < 8; j++) { braces {} are not necessary for single statement blocks