build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46435 )
Change subject: cpu/x86/mtrr: add support for base address bigger than 4GB
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46435/1/src/cpu/x86/mtrr/mtrr.c
File src/cpu/x86/mtrr/mtrr.c:
https://review.coreboot.org/c/coreboot/+/46435/1/src/cpu/x86/mtrr/mtrr.c@450
PS1, Line 450: if (x == 0) return 0;
trailing statements should be on next line
https://review.coreboot.org/c/coreboot/+/46435/1/src/cpu/x86/mtrr/mtrr.c@689
PS1, Line 689: printk(BIOS_DEBUG, "%s %d, uc_deftype_count: %d, wb_deftype_count: %d\n", __func__, __LINE__, uc_deftype_count, wb_deftype_count);
line over 96 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46435
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I41bc5befcc1374c838c91b9f7c5279ea76dd67c7
Gerrit-Change-Number: 46435
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Rocky Phagura
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 14 Oct 2020 22:25:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment