25 Jul
2020
25 Jul
'20
12:11 a.m.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40581 )
Change subject: mb/clevo/n141cu: Add new Comet Lake mainboard ......................................................................
Patch Set 36:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40581/36/src/mainboard/clevo/cml-u/... File src/mainboard/clevo/cml-u/variants/n141cu/include/gpio_table.h:
https://review.coreboot.org/c/coreboot/+/40581/36/src/mainboard/clevo/cml-u/... PS36, Line 20: _PAD_CFG_STRUCT(GPP_A7, 0x44000102, 0x0000001f), this translates to "PAD_CFG_GPI_TRIG_OWN(GPP_A7, NONE, DEEP, OFF, ACPI)" but it should be "PAD_CFG_NF(GPP_A7, NONE, DEEP, NF1)"
--
To view, visit https://review.coreboot.org/c/coreboot/+/40581
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9f83fab64e4cc9036698ca0fdd5edbb677d77eb9
Gerrit-Change-Number: 40581
Gerrit-PatchSet: 36
Gerrit-Owner: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Matt DeVillier matt.devillier@gmail.com
Gerrit-CC: Michael Niewöhner
Gerrit-Comment-Date: Fri, 24 Jul 2020 22:11:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment