Attention is currently required from: Shuo Liu.
Hello Shuo Liu,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/81133?usp=email
to review the following change.
Change subject: arch/x86/include/arch: Add feature check macros ......................................................................
arch/x86/include/arch: Add feature check macros
Add feature check macros for MCE (machine check exception) and MCA (machine check architecture)
Change-Id: I014c25ced1dbe21f35486f8305b1de7669e932d0 Signed-off-by: Shuo Liu shuo.liu@intel.com Signed-off-by: Jincheng Li jincheng.li@intel.com --- M src/arch/x86/include/arch/cpu.h M src/cpu/intel/common/hyperthreading.c 2 files changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/81133/1
diff --git a/src/arch/x86/include/arch/cpu.h b/src/arch/x86/include/arch/cpu.h index 0c4decf..ff59746 100644 --- a/src/arch/x86/include/arch/cpu.h +++ b/src/arch/x86/include/arch/cpu.h @@ -48,8 +48,10 @@ #define X86_VENDOR_UNKNOWN 0xff
#define CPUID_FEATURE_PAE (1 << 6) +#define CPUID_FEATURE_MCE (1 << 7) +#define CPUID_FEATURE_MCA (1 << 14) #define CPUID_FEATURE_PSE36 (1 << 17) -#define CPUID_FEAURE_HTT (1 << 28) +#define CPUID_FEATURE_HTT (1 << 28)
/* Structured Extended Feature Flags */ #define CPUID_STRUCT_EXTENDED_FEATURE_FLAGS 0x7 diff --git a/src/cpu/intel/common/hyperthreading.c b/src/cpu/intel/common/hyperthreading.c index 85c4477..d034129 100644 --- a/src/cpu/intel/common/hyperthreading.c +++ b/src/cpu/intel/common/hyperthreading.c @@ -7,7 +7,7 @@ bool intel_ht_supported(void) { /* Is HyperThreading supported? */ - return !!(cpuid_edx(1) & CPUID_FEAURE_HTT); + return !!(cpuid_edx(1) & CPUID_FEATURE_HTT); }
/*