build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29495 )
Change subject: soc/intel/icelake: Update GPIOs for Icelake SOC ......................................................................
Patch Set 5:
(5 comments)
https://review.coreboot.org/#/c/29495/5/src/mainboard/intel/icelake_rvp/vari... File src/mainboard/intel/icelake_rvp/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/29495/5/src/mainboard/intel/icelake_rvp/vari... PS5, Line 52: /* TBT_CIO_PLUG_EVENT_N */ PAD_CFG_GPI_SCI(GPP_E17, NONE, DEEP, EDGE_SINGLE, NONE), line over 80 characters
https://review.coreboot.org/#/c/29495/5/src/mainboard/intel/icelake_rvp/vari... PS5, Line 56: /* BIOS_REC */ PAD_CFG_GPI(GPP_F5, NONE, PLTRST), please, no space before tabs
https://review.coreboot.org/#/c/29495/5/src/mainboard/intel/icelake_rvp/vari... PS5, Line 84: const struct cros_gpio * __attribute__((weak)) variant_cros_gpios(size_t *num) "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/29495/5/src/mainboard/intel/icelake_rvp/vari... File src/mainboard/intel/icelake_rvp/variants/icl_u/gpio.c:
https://review.coreboot.org/#/c/29495/5/src/mainboard/intel/icelake_rvp/vari... PS5, Line 52: /* TBT_CIO_PLUG_EVENT_N */ PAD_CFG_GPI_SCI(GPP_E17, NONE, DEEP, EDGE_SINGLE, NONE), line over 80 characters
https://review.coreboot.org/#/c/29495/5/src/mainboard/intel/icelake_rvp/vari... File src/mainboard/intel/icelake_rvp/variants/icl_y/gpio.c:
https://review.coreboot.org/#/c/29495/5/src/mainboard/intel/icelake_rvp/vari... PS5, Line 52: /* TBT_CIO_PLUG_EVENT_N */ PAD_CFG_GPI_SCI(GPP_E17, NONE, DEEP, EDGE_SINGLE, NONE), line over 80 characters