[coreboot-gerrit] Change in coreboot[master]: soc/intel/common: Select USE_LEGACY_8254_TIMER

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34709 )

Change subject: soc/intel/common: Select USE_LEGACY_8254_TIMER
......................................................................

Patch Set 2:

(4 comments)

https://review.coreboot.org/c/coreboot/+/34709/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34709/1//COMMIT_MSG@9 
PS1, Line 9: Always select USE_LEGACY_8254_TIMER if we know we have to.
> Better use that information as the commit message summary?

Done

https://review.coreboot.org/c/coreboot/+/34709/1//COMMIT_MSG@11 
PS1, Line 11: Linux kernel/GRUB2
> payload?

no, on disk

https://review.coreboot.org/c/coreboot/+/34709/1//COMMIT_MSG@12 
PS1, Line 12: on X11SSH-TF using SeaBIOS as payload.
> I can boot Linux from harddisk again, thus it doesn't hang any more. […]

Done more test and it breaks SeaBios OptionROM execution and bootmenu timeout.

https://review.coreboot.org/c/coreboot/+/34709/1//COMMIT_MSG@13 
PS1, Line 13:
> Mention the commit breaking this in a Fixes: line?

I don't know the exact commit that made it break.