Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38232 )
Change subject: sb/intel/common: Declare common smbus_base() and enable_smbus()
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38232/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38232/6//COMMIT_MSG@7
PS6, Line 7: smbus_base
Is there any case in which smbus_base() does not return a constant? If so, I think it would be good […]
Read comment below. Call-sites of enable_smbus() will then need to include sb/soc specific headers. There is still lots more to tidy.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38232
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf9893e55949d63f3ceca2249e618d0f81320321
Gerrit-Change-Number: 38232
Gerrit-PatchSet: 6
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 08 Jan 2020 17:56:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment