Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34545 )
Change subject: SPM: mt8183: support spm suspend in coreboot
......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34545/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34545/2//COMMIT_MSG@7
PS2, Line 7: SPM: mt8183: support spm suspend in coreboot
Please use the common prefix (see `git log --oneline`).
https://review.coreboot.org/c/coreboot/+/34545/2//COMMIT_MSG@9
PS2, Line 9: core boot
coreboot
https://review.coreboot.org/c/coreboot/+/34545/2//COMMIT_MSG@10
PS2, Line 10:
Tested how? Why is the SPM firmware needed for suspend?
https://review.coreboot.org/c/coreboot/+/34545/2//COMMIT_MSG@11
PS2, Line 11: Change-Id: I3393a772f025b0912a5a25a63a87512454fbc86e
Please add your Signed-off-by line below.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34545
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3393a772f025b0912a5a25a63a87512454fbc86e
Gerrit-Change-Number: 34545
Gerrit-PatchSet: 2
Gerrit-Owner: DAWEI CHIEN
dawei.chien@mediatek.com
Gerrit-Reviewer: DAWEI CHIEN
dawei.chien@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: SJ Huang
sj.huang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Wed, 24 Jul 2019 12:41:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment