Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47077 )
Change subject: SC7280: Add GPIO driver in coreboot ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47077/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47077/1//COMMIT_MSG@7 PS1, Line 7: SC7280 lowercase for consistency with the other commits.
https://review.coreboot.org/c/coreboot/+/47077/1//COMMIT_MSG@10 PS1, Line 10: Plesae add the datasheet name and revision.
https://review.coreboot.org/c/coreboot/+/47077/1/src/soc/qualcomm/sc7280/gpi... File src/soc/qualcomm/sc7280/gpio.c:
PS1: This looks very similar to `src/soc/qualcomm/sc7180/gpio.c`. Please refactor the code into common code.