Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47603 )
Change subject: intel/fsp2_0: Add weak function soc_fsp_get_version for SoC override
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47603/1/src/drivers/intel/fsp2_0/ut...
File src/drivers/intel/fsp2_0/util.c:
https://review.coreboot.org/c/coreboot/+/47603/1/src/drivers/intel/fsp2_0/ut...
PS1, Line 220:
Uh, since the only change that is needed is to have the `bld_num` field split in two for some FSP versions, why not introduce a Kconfig option FSP_BUILD_VERSION_FORMAT_WORK_WEEK and place a simple check in here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47603
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d2427b7f7a2da9e8fe68e1494a2398b12802adc
Gerrit-Change-Number: 47603
Gerrit-PatchSet: 1
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 15 Nov 2020 11:42:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment