Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37196 )
Change subject: cpu/x86/cache: CLFLUSH programs to memory before running ......................................................................
Patch Set 12:
(5 comments)
https://review.coreboot.org/c/coreboot/+/37196/12/src/cpu/x86/cache/cache.c File src/cpu/x86/cache/cache.c:
https://review.coreboot.org/c/coreboot/+/37196/12/src/cpu/x86/cache/cache.c@... PS12, Line 16: int bool?
https://review.coreboot.org/c/coreboot/+/37196/12/src/cpu/x86/cache/cache.c@... PS12, Line 21: ENV_POSTCAR || ENV_RAMSTAGE Isn't there a symbol for pre-RAM stages?
https://review.coreboot.org/c/coreboot/+/37196/12/src/cpu/x86/cache/cache.c@... PS12, Line 24: CONFIG(X86_CLFLUSH_CAR) Why not place the constant on the left-hand side of the operation?
https://review.coreboot.org/c/coreboot/+/37196/12/src/cpu/x86/cache/cache.c@... PS12, Line 29: uintptr_t types.h
https://review.coreboot.org/c/coreboot/+/37196/12/src/cpu/x86/cache/cache.c@... PS12, Line 33: ram RAM