Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39964 )
Change subject: mb/google/cyan: convert to overridetree ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39964/1/src/mainboard/google/cyan/d... File src/mainboard/google/cyan/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/39964/1/src/mainboard/google/cyan/d... PS1, Line 110: device pci 12.0 off end # 8086 0F16 - SD Port
the overridetree format requires at least one device in each overridetree. […]
Huh, TIL.
https://review.coreboot.org/c/coreboot/+/39964/1/src/mainboard/google/cyan/v... File src/mainboard/google/cyan/variants/edgar/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39964/1/src/mainboard/google/cyan/v... PS1, Line 4:
why? I2C1 is used for the PMIC, should be on for all boards (edgar had it off for no good reason). […]
Because those were the original settings, basically. But if they were wrongly disabled, then just say so in the commit message