Attention is currently required from: Bao Zheng, Raul Rangel, Karthik Ramasubramanian.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71210 )
Change subject: util/amdfwtool: Add option to indicate uncompressed BIOS binary
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
I think forcing the bootblock stage to be loaded uncompressed is a poor design choice, but that has […]
i agree with Martin that it's a bad idea to use an uncompressed bootblock, since one of the major goals is to get the boot times as fast as possible. having the optin doesn't hurt; only using it, so i'll keep this one as resolved
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71210
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d56c0ba451b194043ebb5cdb0f2b27482beef1f
Gerrit-Change-Number: 71210
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 27 Feb 2023 23:15:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Gerrit-MessageType: comment