Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33234 )
Change subject: security/intel/stm: Add STM support ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/33234/6/src/security/intel/stm/SmmStm.c File src/security/intel/stm/SmmStm.c:
https://review.coreboot.org/#/c/33234/6/src/security/intel/stm/SmmStm.c@842 PS6, Line 842: TpmMeasureAndLogData( if CONFIG(TPM1) || CONFIG(TPM2) {}
src/security/tpm/tspi.h: uint32_t tpm_measure_region(const struct region_device *rdev, uint8_t pcr, const char *rname);
We don't use the UEFI TCPA log stuff here. It's just completely broken. See https://doc.coreboot.org/security/vboot/measured_boot.html?highlight=measure...