Attention is currently required from: Jérémy Compostella, Simon Glass.
Hello Felix Singer, Jérémy Compostella, Patrick Georgi, Stefan Reinauer, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/77712?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins)
Change subject: Post-build control of serial ......................................................................
Post-build control of serial
It is annoying to have to create and maintain two completely different builds of coreboot just to enable or disable the console. It would be much more convenient to have a 'silent' flag in the image, which can be updated as needed, without needing to rebuild coreboot.
Introduce the 'coreboot Control Block' (CCB) which can hold such settings. It is designed to be available very early in bootblock, before CBFS is ready. It is able to control the output of the very first bootblock banner.
The CCB is then placed in cbmem so it is available to other stages.
Provide options in cbfstool to get and set settings in the CCB. This makes it easy to use this feature.
BUG=none BRANCH=none TEST=make (to build coreboot) $ cbfstool build/coreboot.rom ccb-get -n serial serial=normal
First try this to see that the bootblock outputs its banner:
$ qemu-system-i386 -bios build/coreboot.rom -nographic |head -5
[NOTE ] coreboot-4.21 Fri Nov 17 12:09:01 UTC 2023 x86_32 bootblock starting (log level: 7)... ...
Now set it to silent and try again, to see that the bootblock output is suppressed, so that the first output shown is the romstage:
$ cbfstool build/coreboot.rom ccb-get -n serial -V silent serial=silent
$ qemu-system-i386 -bios build/coreboot.rom -nographic (no output)
Change-Id: I04e946b33035a493e833500351a0483761252613 Signed-off-by: Simon Glass sjg@chromium.org --- A Documentation/technotes/ccb.md M Documentation/technotes/index.md A Documentation/util/cbfstool/ccb.md M Documentation/util/cbfstool/index.md M src/arch/x86/postcar.c M src/commonlib/bsd/include/commonlib/bsd/cbmem_id.h A src/commonlib/include/commonlib/ccb.h A src/commonlib/include/commonlib/ccb_api.h M src/console/Kconfig M src/console/console.c M src/console/init.c M src/include/console/streams.h M src/include/rules.h M src/lib/Kconfig M src/lib/Makefile.inc M src/lib/bootblock.c A src/lib/ccb.c M src/lib/hardwaremain.c M src/lib/prog_loaders.c M util/cbfstool/cbfstool.c 20 files changed, 509 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/77712/4