Attention is currently required from: Martin L Roth.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80009?usp=email )
Change subject: arch/arm64: Reformat C files with clang-format v16 ......................................................................
Patch Set 1:
(2 comments)
File src/arch/arm64/bl31.c:
https://review.coreboot.org/c/coreboot/+/80009/comment/abe820c4_44dbefb4 : PS1, Line 22: .h = {.type = PARAM_EP,
No, the setting aren't that granular. We only have one setting for alignment with the brace.
Ack, I guess I'll have to get used to it.
File src/arch/arm64/romstage.c:
https://review.coreboot.org/c/coreboot/+/80009/comment/767c34e9_3dfcae00 : PS1, Line 12: { /* no-op, for bring-up */
We can tell it to keep the braces with nothing inside on a single line. […]
Well, I think you have that setting already (see `__aeabi_unwind_cpp_pr0()` in `eabi_compat.c`), it just doesn't catch here because the comment makes the braces "not empty". That's why I'm suggesting moving the comment out.