Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38399 )
Change subject: mb/google/hatch: modify PCIe ports setting for mushu
......................................................................
Patch Set 6: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/38399/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38399/6//COMMIT_MSG@7
PS6, Line 7: mb/google/hatch: modify PCIe ports setting for mushu
Please be specific. […]
mb/google/hatch/var/mushu: Correct PCIe port configuration
https://review.coreboot.org/c/coreboot/+/38399/6/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/mushu/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/38399/6/src/mainboard/google/hatch/...
PS6, Line 87: register "PcieClkSrcClkReq[3]" = "3"
Shouldn’t this be sorted according to port numbers?
I agree. Current order is [13, 8, 7], but it would be more logical to use [7, 8, 13]
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38399
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iea3292be7d8029c35847118228bbb773418632a1
Gerrit-Change-Number: 38399
Gerrit-PatchSet: 6
Gerrit-Owner: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Reviewer: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: John Su
john_su@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 31 Jan 2020 09:48:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment