[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso/acpi: _PIC method must be at root

[Raul Rangel (Code Review)]

Hello Martin Roth, Marshall Dawson, Rob Barnes,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/41437

to review the following change.

Change subject: soc/amd/picasso/acpi: _PIC method must be at root
......................................................................

soc/amd/picasso/acpi: _PIC method must be at root

The _PIC method sets the interrupt model (PIC or APIC). It needs to be
defined at the root level for the kernel to find it. Previously this
method was never getting called, so we were always stuck in APIC mode.

BUG=b:139429446
BRANCH=none
TEST=Saw the method getting called
[    1.251774] ACPI Debug:  "PIC MODE: 0000000000000001"

Signed-off-by: Raul E Rangel 
Change-Id: Idd5e9646df8d56e7cbec2be8b4016c36d81e5fb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+...
Reviewed-by: Marshall Dawson 
Reviewed-by: Rob Barnes 
Reviewed-by: Martin Roth 
---
M src/soc/amd/picasso/acpi/pci_int.asl
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/41437/1

diff --git a/src/soc/amd/picasso/acpi/pci_int.asl b/src/soc/amd/picasso/acpi/pci_int.asl
index 0f3d882..f89a14e 100644
--- a/src/soc/amd/picasso/acpi/pci_int.asl
+++ b/src/soc/amd/picasso/acpi/pci_int.asl
@@ -103,12 +103,13 @@
    	P3PR, 1,
    }

-	Method(_PIC, 0x01, NotSerialized)
+	Method(_PIC, 0x01, NotSerialized)
    {
    	If (Arg0)
    	{
    		_SB.CIRQ()
    	}
+		printf("PIC MODE: %o", Arg0)
    	Store(Arg0, PMOD)
    }