Attention is currently required from: HAOUAS Elyes.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44207 )
Change subject: src/include: Clean up some includes
......................................................................
Patch Set 11:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/44207/comment/392920a2_330abc71
PS11, Line 8:
What's the reason to do this change?
File src/include/symbols.h:
https://review.coreboot.org/c/coreboot/+/44207/comment/60dbb7f1_be595f8f
PS11, Line 6: #include <rules.h>
Don't we auto-include this for all files?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44207
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69c4d21273c9fb400449fd39274f15c0be013402
Gerrit-Change-Number: 44207
Gerrit-PatchSet: 11
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Mon, 01 Feb 2021 10:27:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment