Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34364 )
Change subject: mb/google/octopus/variants/fleex: Remove gpio NC setting for enabling I2C0 ......................................................................
mb/google/octopus/variants/fleex: Remove gpio NC setting for enabling I2C0
Enable I2C0 in fleex then verify EMR function successfully
BUG=b:135968368 BRANCH=octopus TEST=EMR function working normally with I2C0 in Grob360S.
Change-Id: I784ff32418bc839bcec14fbfd7236f708828690e Signed-off-by: Frank Wu frank_wu@compal.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34364 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Marco Chen marcochen@google.com Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/mainboard/google/octopus/variants/fleex/gpio.c 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Marco Chen: Looks good to me, but someone else must approve Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/octopus/variants/fleex/gpio.c b/src/mainboard/google/octopus/variants/fleex/gpio.c index d2d0d64..a1e02d2 100644 --- a/src/mainboard/google/octopus/variants/fleex/gpio.c +++ b/src/mainboard/google/octopus/variants/fleex/gpio.c @@ -21,8 +21,6 @@
static const struct pad_config default_override_table[] = {
- PAD_NC(GPIO_50, UP_20K), - PAD_NC(GPIO_51, UP_20K), PAD_NC(GPIO_52, UP_20K), PAD_NC(GPIO_53, UP_20K), PAD_NC(GPIO_67, UP_20K),