Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39178 )
Change subject: sb/amd: Move smbus to common place ......................................................................
Patch Set 10:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39178/10/src/southbridge/amd/cimx/s... File src/southbridge/amd/cimx/sb800/smbus.h:
https://review.coreboot.org/c/coreboot/+/39178/10/src/southbridge/amd/cimx/s... PS10, Line 19: #define SMBUS_IO_BASE SMBUS0_BASE_ADDRESS This isn't being kept. Was it just unused?
https://review.coreboot.org/c/coreboot/+/39178/10/src/southbridge/amd/cimx/s... File src/southbridge/amd/cimx/sb800/smbus.c:
https://review.coreboot.org/c/coreboot/+/39178/10/src/southbridge/amd/cimx/s... PS10, Line 66: printk(BIOS_DEBUG, "SB800 - Smbus.c - do_smbus_recv_byte - smbus not ready.\n"); Do we want to keep these printk() calls? Maybe as a debug option?
https://review.coreboot.org/c/coreboot/+/39178/10/src/vendorcode/amd/cimx/sb... File src/vendorcode/amd/cimx/sb800/SB800.h:
https://review.coreboot.org/c/coreboot/+/39178/10/src/vendorcode/amd/cimx/sb... PS10, Line 709: AX_INDXP 1 In the locations that were kept, this is defined as 2. What's the difference?