Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39810 )
Change subject: memranges: Change align attribute to be log2 of required alignment
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39810/2/src/include/memrange.h
File src/include/memrange.h:
https://review.coreboot.org/c/coreboot/+/39810/2/src/include/memrange.h@29
PS2, Line 29: size_t align;
Is size_t still justified here, struct resource uses unsigned char.
Valid point. I think it makes sense to switch to unsigned char.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39810
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie4d3868cdff55b2c7908b9b3ccd5f30a5288e62f
Gerrit-Change-Number: 39810
Gerrit-PatchSet: 2
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Wed, 25 Mar 2020 06:50:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment