Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44047 )
Change subject: Change all assert(0) to BUG()
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44047/1/src/device/device_const.c
File src/device/device_const.c:
https://review.coreboot.org/c/coreboot/+/44047/1/src/device/device_const.c@1...
PS1, Line 187: BUG();
Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
*smacks Jenkins with a broom* This is not the kernel!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44047
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I674e5f8ec7f5fe8b92b1c7c95d9f9202d422ce32
Gerrit-Change-Number: 44047
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 30 Jul 2020 15:59:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment