Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Angel Pons, Felix Held.
Fabio Aiuto has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68101 )
Change subject: include/device/device_util.c: add predicates for pci devices
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68101/comment/b6adf1c1_adadd4a4
PS1, Line 7: add helpers to check pci device enabled
Hmmm, this is a bit confusing, how about: […]
Ack
Patchset:
PS2:
thanks for review
File src/device/device_util.c:
https://review.coreboot.org/c/coreboot/+/68101/comment/60c6e548_2658ad4d
PS1, Line 971: pci->bus->dev->path.type
Why does this access the bus info? Can any of these pointers be NULL? The parameter itself can be NU […]
Ops, you are right, fixed
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68101
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3257c8404017372f6cdd9f6cf9453502447343a0
Gerrit-Change-Number: 68101
Gerrit-PatchSet: 2
Gerrit-Owner: Fabio Aiuto
fabioaiuto83@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 05 Oct 2022 08:06:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment