Attention is currently required from: Jason Glenesk, Marshall Dawson. Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/57321 )
Change subject: [TEST] mb/amd/mandolin: use AMD_SOC_SEPARATE_EFS_SECTION ......................................................................
[TEST] mb/amd/mandolin: use AMD_SOC_SEPARATE_EFS_SECTION
Move the EFS to the lowest possible position inside the flash by adding an EFS FMAP section right after the EC firmware FMAP section and selecting AMD_SOC_SEPARATE_EFS_SECTION.
TEST=Mandolin still boots.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I372bcc60943a42b511cea1fdd451a15ad420a679 --- M src/mainboard/amd/mandolin/Kconfig M src/mainboard/amd/mandolin/variants/mandolin/board.fmd 2 files changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/57321/1
diff --git a/src/mainboard/amd/mandolin/Kconfig b/src/mainboard/amd/mandolin/Kconfig index 50b3e5d..96f14ab 100644 --- a/src/mainboard/amd/mandolin/Kconfig +++ b/src/mainboard/amd/mandolin/Kconfig @@ -12,6 +12,7 @@ select HAVE_ACPI_RESUME select DRIVERS_UART_ACPI select AMD_SOC_CONSOLE_UART if !AMD_LPC_DEBUG_CARD + select AMD_SOC_SEPARATE_EFS_SECTION if BOARD_AMD_MANDOLIN
config FMDFILE default "src/mainboard/amd/mandolin/variants/$(CONFIG_VARIANT_DIR)/board.fmd" @@ -69,7 +70,6 @@
config AMD_FWM_POSITION_INDEX int - default 3 if BOARD_AMD_MANDOLIN default 4 if BOARD_AMD_CEREME help TODO: might need to be adapted for better placement of files in cbfs diff --git a/src/mainboard/amd/mandolin/variants/mandolin/board.fmd b/src/mainboard/amd/mandolin/variants/mandolin/board.fmd index 33b281d..1296b85 100644 --- a/src/mainboard/amd/mandolin/variants/mandolin/board.fmd +++ b/src/mainboard/amd/mandolin/variants/mandolin/board.fmd @@ -1,6 +1,7 @@ FLASH@0xFF800000 8M { BIOS { EC 128K + EFS 3M RW_MRC_CACHE 64K FMAP 4K COREBOOT(CBFS)