[coreboot-gerrit] [M] Change in coreboot[master]: soc/amd: Move "smu.c" to common

[Felix Held (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Elyes Haouas.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69338 )

Change subject: soc/amd: Move "smu.c" to common
......................................................................

Patch Set 1:

(1 comment)

Patchset:

PS1:
> it seems a little confusing to me to have both `soc/amd/common/smu. […]

i don't remember why i left that part in a per-soc file, but the parts that aren't consistent are already factored out in soc-specific include files, so i don't see a strong reason to not fatcor this out to common amd soc code.
when moving it to the common code, it should be moved to a new file in soc/amd/common/block/smu/ and smu_s3.c would be the name i'd choose. instead of including the common file in the soc-specific makefile, it would be cleaner to introduce a new kconfig option to include this in the build and select that from the socs