Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31377 )
Change subject: util/ifdtools: Make EC region readable to BIOS/CPU ......................................................................
util/ifdtools: Make EC region readable to BIOS/CPU
Allow EC region to be readable by BIOS/CPU so that flashrom can read it.
BUG=b:123199222 TEST=Build coreboot with CONFIG_LOCK_MANAGEMENT_ENGINE set, run firmware_LockedME test.
Change-Id: I306c74a0893355e57632a22a712b1f4fdaa19306 Signed-off-by: Bora Guvendik bora.guvendik@intel.com Reviewed-on: https://review.coreboot.org/c/31377 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Duncan Laurie dlaurie@chromium.org --- M util/ifdtool/ifdtool.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved
diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index 85623fd..a97f352 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -969,8 +969,8 @@ case PLATFORM_CNL: case PLATFORM_ICL: case PLATFORM_SKLKBL: - /* CPU/BIOS can read descriptor, BIOS and GbE. */ - fmba->flmstr1 |= 0xb << rd_shift; + /* CPU/BIOS can read descriptor, BIOS, EC and GbE. */ + fmba->flmstr1 |= 0x10b << rd_shift; /* CPU/BIOS can write BIOS and Gbe. */ fmba->flmstr1 |= 0xa << wr_shift; /* ME can read descriptor, ME and GbE. */