[coreboot-gerrit] Change in ...coreboot[master]: i945,ICH7: Write on RPFN only once

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31005 )

Change subject: i945,ICH7: Write on RPFN only once
......................................................................

Patch Set 2: Code-Review+1

(4 comments)

https://review.coreboot.org/#/c/31005/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/31005/2//COMMIT_MSG@7 
PS2, Line 7: Write on
Just *Write* without *on*.

https://review.coreboot.org/#/c/31005/2//COMMIT_MSG@7 
PS2, Line 7: i945,ICH7
Maybe:
> intel/i945,ich7: …

https://review.coreboot.org/#/c/31005/2//COMMIT_MSG@10 
PS2, Line 10: Drop the romstage write.
Do both write the same value? Why drop the romstage one?

From `src/southbridge/intel/i82801gx/pcie.c`:

RCBA32(RPFN) = rpc.new_rpfn;

https://review.coreboot.org/#/c/31005/2//COMMIT_MSG@11 
PS2, Line 11: 
Tested how?