Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37730 )
Change subject: util/autoport: correct build errors of produced files ......................................................................
Patch Set 2:
(5 comments)
Patch Set 2:
(5 comments)
This is full of unrelated cosmetic changes that need a commit message. Please split.
You are right. The cosmetic changes are things I would otherwise have to change or comment on each and every autoport usage.
https://review.coreboot.org/c/coreboot/+/37730/2/util/autoport/azalia.go File util/autoport/azalia.go:
https://review.coreboot.org/c/coreboot/+/37730/2/util/autoport/azalia.go@a55 PS2, Line 55: Audio controller
What is fixed by removing this? Isn't it just an informational string?
It results in "High Definition Audio Audio Controller"
https://review.coreboot.org/c/coreboot/+/37730/2/util/autoport/bd82x6x.go File util/autoport/bd82x6x.go:
https://review.coreboot.org/c/coreboot/+/37730/2/util/autoport/bd82x6x.go@a2... PS2, Line 279: PCI-
Why drop this?
It is kind of redundant, results in "LPC bridge PCI-LPC bridge". I might as well drop it altogether.
https://review.coreboot.org/c/coreboot/+/37730/2/util/autoport/main.go File util/autoport/main.go:
https://review.coreboot.org/c/coreboot/+/37730/2/util/autoport/main.go@821 PS2, Line 821: fmt.Fprintf(bi, "Flashrom support: %s\n", FlashROMSupport)
What is the reason for the changes here?
It's easier to complete the fields that way. Also, I dropped the release year because it is of little use (I find it hard to determine the release year of a board, and it doesn't even appear on board_status anyway).
https://review.coreboot.org/c/coreboot/+/37730/2/util/autoport/sandybridge.g... File util/autoport/sandybridge.go:
https://review.coreboot.org/c/coreboot/+/37730/2/util/autoport/sandybridge.g... PS2, Line 137: RegisterPCI(0x8086, id, GenericVGA{GenericPCI{Comment: "VGA controller"}})
Why?
Results in "Integrated Graphics VGA Controller", which is rather obnoxious.
https://review.coreboot.org/c/coreboot/+/37730/2/util/autoport/sandybridge.g... PS2, Line 15: `)
Hmmmm, I wonder if we should drop this. There is no reason to run […]
I dropped the whole mainboard.c on (IIRC) Asus P8H61-M PRO, so it's a good idea