Patch Set 2:

(5 comments)

This is full of unrelated cosmetic changes that need a commit message. Please split.

You are right. The cosmetic changes are things I would otherwise have to change or comment on each and every autoport usage.

View Change

5 comments:

• File util/autoport/azalia.go:

  • Patch Set #2, Line 55: Audio controller

    What is fixed by removing this? Isn't it just an informational string?

    It results in "High Definition Audio Audio Controller"

• File util/autoport/bd82x6x.go:

  • Patch Set #2, Line 279: PCI-

    Why drop this?

    It is kind of redundant, results in "LPC bridge PCI-LPC bridge". I might as well drop it altogether.

• File util/autoport/main.go:

  • Patch Set #2, Line 821: fmt.Fprintf(bi, "Flashrom support: %s\n", FlashROMSupport)

    What is the reason for the changes here?

    It's easier to complete the fields that way. Also, I dropped the release year because it is of little use (I find it hard to determine the release year of a board, and it doesn't even appear on board_status anyway).

• File util/autoport/sandybridge.go:

  • Patch Set #2, Line 137: RegisterPCI(0x8086, id, GenericVGA{GenericPCI{Comment: "VGA controller"}})

    Why?

    Results in "Integrated Graphics VGA Controller", which is rather obnoxious.

  • Patch Set #2, Line 15: `)

    Hmmmm, I wonder if we should drop this. There is no reason to run […]

    I dropped the whole mainboard.c on (IIRC) Asus P8H61-M PRO, so it's a good idea

To view, visit change 37730. To unsubscribe, or for help writing mail filters, visit settings.