Attention is currently required from: Felix Singer, Nico Huber, Angel Pons. Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 170:
(4 comments)
File src/mainboard/acer/aspire_vn7_572g/bootblock.c:
https://review.coreboot.org/c/coreboot/+/35523/comment/499c7f93_8b64cf0e PS165, Line 1: /* SPDX-License-Identifier: GPL-2.0-or-later */
Thanks for the explanation. Well, I don't mind. I just wondered why it is mixed.
I'm not a lawyer, but if coreboot and the Linux kernel use GPLv2, I'll stick to that for simplicity.
File src/mainboard/acer/aspire_vn7_572g/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35523/comment/697f673e_4b891994 PS165, Line 185: device domain 0 on
The original idea was to allow boards to remove some SoC devices from being exposed to user configur […]
Done
File src/mainboard/acer/aspire_vn7_572g/gpio.h:
PS165: Is this, like CB:48823, intended to minimise the likelihood of mistaken usages? Otherwise, I can't see how the tables would be used multiple times.
If each definition is used in exactly one compilation unit, the definitions can instead be placed directly into the corresponding compilation unit
But this isn't to reduce the number of files, clearly.
Regardless, I have no strong opinions on this, so we'll do it for the sake of consistency.
File src/mainboard/acer/aspire_vn7_572g/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35523/comment/aaa260f9_2bb365c5 PS165, Line 53: mainboard_enable
As mentioned on CB:43852, I'll wait for a commit that adapts the rest of the tree, to keep consisten […]
Done