[coreboot-gerrit] Change in coreboot[master]: mediatek/mt8183: Init SPM driver

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34545 )

Change subject: mediatek/mt8183: Init SPM driver
......................................................................

Patch Set 12:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34545/12/src/mainboard/google/kukui... 
File src/mainboard/google/kukui/mainboard.c:

https://review.coreboot.org/c/coreboot/+/34545/12/src/mainboard/google/kukui... 
PS12, Line 59: spm_init(get_dram_type());
I don't think this will work.

the get_sdram_config was only called in ROM stage, and your get_dram_type won't call get_sdram_config; which means when we call this in RAM stage, it'll be actually reading the static variable, which is only initialized to 0.

So we should just call get_sdram_config and pass the params.dram_type to spm_init.