Roja Rani Yarubandi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36517 )
Change subject: sc7180: Add SPI QUP driver
......................................................................
Patch Set 5:
(2 comments)
Patch Set 5:
(2 comments)
Done the changes, will share patch with Mike soon
https://review.coreboot.org/c/coreboot/+/36517/5/src/mainboard/google/trogdo...
File src/mainboard/google/trogdor/bootblock.c:
https://review.coreboot.org/c/coreboot/+/36517/5/src/mainboard/google/trogdo...
PS5, Line 24: qup_spi_init(QUPV3_0_SE0, 1010 * KHz); /* H1 SPI */
...and QUPV3_1_SE0 here.
Done
https://review.coreboot.org/c/coreboot/+/36517/5/src/mainboard/google/trogdo...
PS5, Line 25: qup_spi_init(QUPV3_1_SE4, 1010 * KHz); /* EC SPI */
Sorry, actually it should be QUPV3_0_SE0 here...
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36517
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I86f4fcff6f9537373f70a43711130d7f28bd5e09
Gerrit-Change-Number: 36517
Gerrit-PatchSet: 5
Gerrit-Owner: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Akash Asthana
akashast@qualcomm.corp-partner.google.com
Gerrit-CC: Roja Rani Yarubandi
c_rojay@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Fri, 22 Nov 2019 10:02:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment
