Attention is currently required from: Daniel Maslowski, Maxim Polyakov.
Maximilian Brune has posted comments on this change by Maxim Polyakov. ( https://review.coreboot.org/c/coreboot/+/70308?usp=email )
Change subject: util/intelp2m/config: Rework configuration package
......................................................................
Patch Set 17: Code-Review+2
(1 comment)
File util/intelp2m/platforms/apl/macro.go:
https://review.coreboot.org/c/coreboot/+/70308/comment/406e99b3_094d9766?usp... :
PS17, Line 132: &
nit:
looks worse then before in my opinion.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70308?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia1b19ae3122bcf6ec740ae4683d62f31570670b1
Gerrit-Change-Number: 70308
Gerrit-PatchSet: 17
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Daniel Maslowski
info@orangecms.org
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Daniel Maslowski
info@orangecms.org
Gerrit-Attention: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Comment-Date: Wed, 26 Feb 2025 18:24:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes