[coreboot-gerrit] Change in coreboot[master]: security/tpm/tss/tcg-2.0: Add TPM2 function tlcl_getcapability()

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30826 )

Change subject: security/tpm/tss/tcg-2.0: Add TPM2 function tlcl_getcapability()
......................................................................

Patch Set 18:

(3 comments)

https://review.coreboot.org/c/coreboot/+/30826/9//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/30826/9//COMMIT_MSG@9 
PS9, Line 9: Add function tlcl_getcapability() to return TPM2 capability.
> I will split this into 3 CLs. […]

Done

https://review.coreboot.org/c/coreboot/+/30826/4/src/security/tpm/tss/tcg-2.... 
File src/security/tpm/tss/tcg-2.0/tss.c:

https://review.coreboot.org/c/coreboot/+/30826/4/src/security/tpm/tss/tcg-2.... 
PS4, Line 290: 	printk(BIOS_SPEW, "%s: tlcl_init_done is %d\n", __func__, done);
> Do we need to permanently merge these? They seem excessive even for SPEW...

Done

https://review.coreboot.org/c/coreboot/+/30826/4/src/security/tpm/tss/tcg-2.... 
PS4, Line 531: 	for (index = 0; index < ARRAY_SIZE(mHashInfo); index++)
> nit: maybe that's just me, but wouldn't a switch() statement look better than parsing an array from  […]

Done