[coreboot-gerrit] Change in coreboot[master]: vc/amd/pi: Allow 00670F00 to build with no binaryPI

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37228 )

Change subject: vc/amd/pi: Allow 00670F00 to build with no binaryPI
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37228/1/src/vendorcode/amd/pi/00670... 
File src/vendorcode/amd/pi/00670F00/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/37228/1/src/vendorcode/amd/pi/00670... 
PS1, Line 122: unlikely
> From my understanding...

No, it's not a temporary step.  This is the final condition.  If you do not specify a binaryPI file, you can build an image but it won't boot.  In the event you USE_BLOBS and USE_AMD_BLOBS, then there is a default path/to/file specified.
> impossible...

I didn't want to split too many hairs or worry about precisely where it would stop.  Assuming some die() doesn't get us, there will be no DRAM, etc.  However, unlike in Intel with no IFD or ME, the x86 should function OK.